fix(sort): apply sort to 1-axis charts#175
Merged
Merged
Conversation
Remove legacy preserveRows override that forced category-scatter path for solo --select embeds. Add mixed-tuple sorting in finalize for preserveRows charts without series.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes sort not affecting 1-axis charts when using
--sort asc/--sort desc(e.g.vizb bar examples/csv/sales.csv -o index.html --sort asc). The sort toggle worked in the UI but bar order did not change.Root cause
1-axis charts were often routed through the
mixedTuplespath becauseDashboard.vuehad a legacy override that forcedpreserveRows=truefor solo--selectembeds (axes.length === 1 && axes[0].key === 'x'), even when Go setpreserveRows: falsefor auto-grouped data.That path skipped
sortSeriesByTotal(which only runs whenseries.length > 0) and rendered tuples as-is.Changes
preserveRowsoverride inDashboard.vue— honor onlyactiveDataSet.preserveRows === truefinalize.tsforpreserveRowscharts without seriestransform.test.tspkg/template/vizb-ui.gen.go)Test plan
cd ui && pnpm test— 416 tests passindex.htmlwith--sort ascand confirm asc/desc toggle reorders bars