fix(scatter): apply visualMap on large datasets and add house-price example#172
Merged
Merged
Conversation
…xample - Disable ECharts scatter `large` mode when visualMap is enabled so gradient coloring works regardless of point count - Replace-merge series on ChartScatter updates so UI toggle takes effect - Use cross axisPointer for value-mode scatter tooltips - Add house-price-area2.csv example and CI deploy matrix entry
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 2D scatter
--visualmapnot applying gradient colors on large datasets (e.g. 16k+ points) and adds a house-price CSV example to CI.Problem
ECharts skips
visualMapwhen scatter series runs inlargemode. Vizb always enabledlarge: trueabove 2,000 points, so--visualmapshowed the gradient control but points stayed a single color.Changes
scatterSeriesLargeOpts()— when visualMap is on, setlarge: false; otherwise keep the performance path (large: true, threshold 2000)ChartScatter.vue—replaceMerge: ['series', 'visualMap']so toggling visualMap in the UI clears stalelarge: trueaxisPointerwhen both axes are value typehouse-price-area2.csv— 16,174-row ECharts house-price demo data07-house-price-area2withscatter:visualmapTesting