feat(dataset): add --id flag and ?id= URL dataset selection#171
Merged
Conversation
Introduce a top-level dataset id field set via --id on the root command and chart subcommands. The UI prefers ?id= for deep links when present, falling back to the legacy ?d= index param. Existing ids are preserved on passthrough and are never overwritten.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Drop unreachable dataset-load defer in useUrlRouter, shorten --id help, and remove redundant tests that duplicate resolveDatasetIndex wiring.
Add CLI flag reference on root and chart subcommands, a deep-links section in the UI overview, and update examples/README copy to explain ?id= vs ?d= URL selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a stable top-level
idfield on datasets, set via--idon the root command and chart subcommands. The UI uses?id=for deep links when a dataset has an id, falling back to the legacy?d=index param otherwise.Changes
Dataset.IDfield,--iddata flag, pipeline wiring inassembleDatasetDataSet.idtype, URL router prefers?id=over?d=pkg/template/vizb-ui.gen.goBehavior
idis top-level on the dataset object (not insidemeta)?id=takes precedence over?d=when both are present in the URLUsage
vizb data.csv --id sales-auto -o out.html # Deep link: out.html?id=sales-auto