fix(charts): fit y-axis to data range for line and scatter charts#163
Merged
Conversation
ECharts includes zero on linear value axes by default, which wastes vertical space on line and scatter charts whose values never approach zero. Add a fitYAxisToData option to createAxisConfig and createValueAxisConfig that sets yAxis.scale = true for line/scatter while bar charts keep the zero baseline. Includes unit tests and regenerated UI bundle.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ECharts includes zero on linear value axes by default, which wastes vertical space on line and scatter charts whose values never approach zero. This PR adds a
fitYAxisToDataoption that setsyAxis.scale = truefor line and scatter charts while bar charts keep the zero baseline.Changes
fitYAxisToDataparameter tocreateAxisConfigandcreateValueAxisConfigpkg/template/vizb-ui.gen.go)Test plan
pnpm vitest run src/composables/charts/shared/chartConfig.test.ts— 23 tests pass