fix(ui): hide axis titles when dimension labels are unset#150
Merged
Conversation
Stop falling back to axis keys (x/y) in axisLabels so 2D bar, line, and scatter charts no longer render default axis names. Pie charts still show dimension titles in the dual-axis layout via their own fallbacks.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2D bar, line, and scatter charts no longer show default
x/yaxis titles when a dimension has no human-readable label from--group. Axis titles render only when an explicit label is provided.Pie charts are unchanged: dual-axis pie layouts still show dimension titles via their own fallbacks (
X-Axis/Y-Axis).Changes
x,y,z) when buildingaxisLabelsintransform.tsandDashboard.vuenameon truthy labels, so no composable changes were neededaxisLabelsin value/group scatter paths and inbuildValueModeChartTest plan
npm test -- --run src/lib/transform.test.tsnpm test -- --run src/composables/charts/useScatterChartOptions.test.ts