chore: clarify --filter flag description for CSV/JSON and benchmarks#146
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies the
--filterflag documentation and ships related UI polish for 3D charts, plus a fix for embedded UI sync verification.--filterflag descriptionUpdates the
--filter/-fflag description across CLI help, docs, and the GitHub Action so it matches actual behavior:--grouplabelReplaces the previous wording ("data labels / series names"), which implied column/series filtering for tabular data.
New description:
Files:
cmd/cli/options.godocs/src/content/docs/commands/root.mdxdocs/src/content/docs/commands/charts.mdxdocs/src/content/docs/ci-cd/github-action.mdxdocs/src/content/docs/features.mdxaction.yml3D chart UI
Fixes
grid3D.axisPointerstyling so hover crosshairs are visible in both themes (ECharts GL defaults to near-black lines/labels).axisColorat full opacity (width: 2)textColorinstead of ECharts GL’s default white label textopacitydark0.15, light0.4) with an extra×0.75fade in 3D grids so the box reads less bright while the pointer stays readableFiles:
ui/src/composables/charts/shared/3d.tsui/src/composables/charts/shared/chartConfig.tsui/src/composables/charts/shared/3d.test.tspkg/template/vizb-ui.gen.go(regenerated embedded UI assets)vizb-ui.gen.gosync test fixverify-gen-sync.test.tspreviously hardcoded a Vite chunk hash (e.g.axisAlignTicks-lwmJPqWv). That broke whenever the UI was rebuilt and chunk names changed.ui/embed-build/gen-go-parse.tsverify-gen-sync.tsto a CLI wrapper around the shared moduleVizbChunksat runtime and locate lines by key (handles padded alignment in generated Go)This keeps sync verification stable across UI rebuilds without manually updating chunk hashes in tests.