feat(charts): add chart total badge and improve 3D tooltips#141
Merged
Conversation
- Show Total badge on ChartCard for all axis shapes (1D/2D/3D) - Offer value-mode 3D toggle when x+y data and the 3D engine are present - Align grouped and value-mode 3D tooltip layout with per-axis marginals before combined Σ(x+y) and Σ(x+y+z) sums - Move grouped 3D grand total from tooltip to the ChartCard badge - Add computeChartGrandTotal/formatChartTotal helpers and tests
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChartCardfor all axis shapes (1D, 2D, grouped 3D, value-mode 3D), summing plotted metric values and respecting hidden z-legend series--3don the CLIChanges
computeChartGrandTotal/formatChartTotalhelpers inui/src/lib/utils.tscanOfferValue3D,datasetHasBothXY,datasetHas3DEnginefor 3D toggle visibilityui/src/composables/charts/shared/3d.tsutils.test.ts,3d.test.ts, settings/shape tests)Test plan
pnpm testinui/— 265 tests passinggo test ./...— all packages passing