fix(charts): simplify grid bottom to dataZoom-only branching#138
Merged
Conversation
Reserve the large fixed bottom band only when the dataZoom slider is shown. Without dataZoom, use a 28px tick band with containLabel so axis titles and rotated ticks fit without shrinking plot height. Bump axis title font to 16px and drop hasXAxisName/hasRotatedLabels grid options.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Extract a badge-sized button component and use it for the chart stats toggle so it aligns visually with axis count badges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies bar/line chart bottom layout so grid spacing only branches on dataZoom presence, not axis title or rotated labels.
Changes
bottom: 100px,containLabel: false(unchanged)bottom: 28pxwithcontainLabel: true— ECharts automatically absorbs axis title and rotated tick space, preserving plot height whether or not an axis title is presenthasXAxisName/hasRotatedLabelsgrid options from bar/line composablespkg/template/vizb-ui.gen.go)Testing
pnpm vitest run src/composables/charts/shared/chartConfig.test.ts