Skip to content

Commit 39e687a

Browse files
authored
test: do not double-quote errors in logs (#116)
Signed-off-by: Aofei Sheng <[email protected]>
1 parent 239fd87 commit 39e687a

File tree

6 files changed

+159
-159
lines changed

6 files changed

+159
-159
lines changed

cacher_test.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,29 @@ func TestDirCacher(t *testing.T) {
1616
dirCacher := DirCacher(t.TempDir())
1717

1818
if err := dirCacher.Put(context.Background(), "a/b/c", strings.NewReader("foobar")); err != nil {
19-
t.Fatalf("unexpected error %q", err)
19+
t.Fatalf("unexpected error %v", err)
2020
}
2121

2222
if fi, err := os.Stat(filepath.Join(string(dirCacher), filepath.FromSlash("a/b"))); err != nil {
23-
t.Errorf("unexpected error %q", err)
23+
t.Errorf("unexpected error %v", err)
2424
} else if got, want := fi.Mode().Perm(), os.FileMode(0o755).Perm(); got != want {
2525
t.Errorf("got %d, want %d", got, want)
2626
}
2727

2828
if fi, err := os.Stat(filepath.Join(string(dirCacher), filepath.FromSlash("a/b/c"))); err != nil {
29-
t.Errorf("unexpected error %q", err)
29+
t.Errorf("unexpected error %v", err)
3030
} else if got, want := fi.Mode().Perm(), os.FileMode(0o644).Perm(); got != want {
3131
t.Errorf("got %d, want %d", got, want)
3232
}
3333

3434
if rc, err := dirCacher.Get(context.Background(), "a/b/c"); err != nil {
35-
t.Errorf("unexpected error %q", err)
35+
t.Errorf("unexpected error %v", err)
3636
} else if rc == nil {
3737
t.Error("unexpected nil")
3838
} else if b, err := io.ReadAll(rc); err != nil {
39-
t.Errorf("unexpected error %q", err)
39+
t.Errorf("unexpected error %v", err)
4040
} else if err := rc.Close(); err != nil {
41-
t.Errorf("unexpected error %q", err)
41+
t.Errorf("unexpected error %v", err)
4242
} else if got, want := string(b), "foobar"; got != want {
4343
t.Errorf("got %q, want %q", got, want)
4444
}
@@ -52,7 +52,7 @@ func TestDirCacher(t *testing.T) {
5252
t.Fatal("expected error")
5353
}
5454
if got, want := err, fs.ErrNotExist; !compareErrors(got, want) {
55-
t.Errorf("got %q, want %q", got, want)
55+
t.Errorf("got %v, want %v", got, want)
5656
}
5757
if got := rc; got != nil {
5858
t.Errorf("got %#v, want nil", got)
@@ -73,17 +73,17 @@ func TestDirCacher(t *testing.T) {
7373
t.Fatal("expected error")
7474
}
7575
if got, want := err, errRead; !compareErrors(got, want) {
76-
t.Errorf("got %q, want %q", got, want)
76+
t.Errorf("got %v, want %v", got, want)
7777
}
7878
})
7979

8080
t.Run("PutWithInvalidDirectory", func(t *testing.T) {
8181
cacheDir := t.TempDir()
8282
if err := os.MkdirAll(filepath.Join(cacheDir, filepath.FromSlash("a/b")), 0o755); err != nil {
83-
t.Fatalf("unexpected error %q", err)
83+
t.Fatalf("unexpected error %v", err)
8484
}
8585
if err := os.WriteFile(filepath.Join(cacheDir, filepath.FromSlash("a/b/c")), []byte("foobar"), 0o644); err != nil {
86-
t.Fatalf("unexpected error %q", err)
86+
t.Fatalf("unexpected error %v", err)
8787
}
8888
dirCacher := DirCacher(filepath.Join(cacheDir, filepath.FromSlash("a/b/c")))
8989

0 commit comments

Comments
 (0)