compiler: vendor golang.org/x/tools/go/gcimporter15 #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 5dfd8930f264888dd5fe26820a0ac605a384dd33 golang.org/x/tools/go/gcimporter15 has been removed (in line with a promise to remove this old API). This CL vendors a copy of golang.org/x/tools/go/gcimporter15 as of 14d5b80f954f510ba9bcd241821b6f4828498e1a (5dfd8930f264888dd5fe26820a0ac605a384dd33~1) minus *_test.go files and the testdata directory (which contained binary files). This is effectively a sticking plaster until we migrate, per the deprecation notice, to golang.org/x/tools/go/gcexportdata. Fixes gopherjs#788
myitcv
force-pushed
the
vendor_gcimporter15
branch
from
172f8c0 to
2b066ec
Compare
Member
Author
|
Thanks @shurcooL Please can either you or @hajimehoshi merge this assuming you're happy? Which reminds me: we still need to sort out my Github permissions for this repo! |
|
+1 holding our breath downstream :) |
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 21, 2018
This is a follow up to gopherjs#789 that removes the sticking plaster in that PR, and switches the compiler to using golang.org/x/tools/go/gcexportdata as directed here https://github.com/golang/tools/blob/14d5b80f954f510ba9bcd241821b6f4828498e1a/go/gcimporter15/gcimporter.go#L13-L14. This means we can also remove the temporary vendor of gcimporter15.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 21, 2018
This is a follow up to gopherjs#789 that removes the sticking plaster in that PR, and switches the compiler to using golang.org/x/tools/go/gcexportdata as directed here https://github.com/golang/tools/blob/14d5b80f954f510ba9bcd241821b6f4828498e1a/go/gcimporter15/gcimporter.go#L13-L14. This means we can also remove the temporary vendor of gcimporter15.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 22, 2018
This is a follow up to gopherjs#789 that removes the sticking plaster in that PR, and switches the compiler to using golang.org/x/tools/go/gcexportdata as directed here https://github.com/golang/tools/blob/14d5b80f954f510ba9bcd241821b6f4828498e1a/go/gcimporter15/gcimporter.go#L13-L14. This means we can also remove the temporary vendor of gcimporter15.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 22, 2018
This is a follow up to gopherjs#789 that removes the sticking plaster in that PR, and switches the compiler to using golang.org/x/tools/go/gcexportdata as directed here https://github.com/golang/tools/blob/14d5b80f954f510ba9bcd241821b6f4828498e1a/go/gcimporter15/gcimporter.go#L13-L14. This means we can also remove the temporary vendor of gcimporter15. However we instead vendor golang.org/x/tools/go/gcexportdata and golang.org/x/tools/go/internal/gcimporter to avoid hassle for people upgrading to this version of GopherJS. We do this as of https://github.com/golang/tools/tree/94b14834a20132093826ea5e2da5502a13908ad3, minus *_test.go files and testdata directories.
myitcv
added a commit
to myitcv/gopherjs
that referenced
this pull request
Apr 23, 2018
This is a follow up to gopherjs#789 that removes the sticking plaster in that PR, and switches the compiler to using golang.org/x/tools/go/gcexportdata as directed here https://github.com/golang/tools/blob/14d5b80f954f510ba9bcd241821b6f4828498e1a/go/gcimporter15/gcimporter.go#L13-L14. This means we can also remove the temporary vendor of gcimporter15.
dmitshur
pushed a commit
that referenced
this pull request
Apr 24, 2018
This change updates compiler to use new package gcexportdata instead of the deprecated and removed package gcimporter15 for reading and writing export data files containing type information. See its deprecation note here: https://github.com/golang/tools/blob/14d5b80f954f510ba9bcd241821b6f4828498e1a/go/gcimporter15/gcimporter.go#L13-L14 Remove vendored copy of gcimporter15, since it's no longer used. Updates #789.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of https://github.com/golang/tools/tree/5dfd8930f264888dd5fe26820a0ac605a384dd33
golang.org/x/tools/go/gcimporter15 has been removed (in line with a
promise to remove this old API). This CL vendors a copy of
golang.org/x/tools/go/gcimporter15 as of
https://github.com/golang/tools/tree/14d5b80f954f510ba9bcd241821b6f4828498e1a
(5dfd8930f264888dd5fe26820a0ac605a384dd33~1) minus *_test.go files and
the testdata directory (which contained binary files).
This is effectively a sticking plaster until we migrate, per the
deprecation notice, to golang.org/x/tools/go/gcexportdata.
Fixes #788