When splitting up the compiler I noticed that there is an internal structure for storing parsed files called sources. sources is very similar to the structure I added ParsedPackage used to split the parse and compile phases apart. I joined these two into one shared Sources structure to save some moving of information around and complexity.

These changes should not affect functionality. It is a refactor to simplify and organize how data prior to the Archives is stored.

After this change: Build will load all the packages needed for a project into Sources. The root Sources is passed into Compile where the Sources will be sorted, type checked, etc before being compiled into JS.

In following tickets the Sources sorting, type checking, and the creation of the rootCtx will be moved out of Compile so that they can be performed on all Sources at the same time, thus allowing generic information to be passed across package boundaries.

This is related to #1013 and #1270

Changes

• Moved errorList into its own package (errorList.ErrorList) so that it can be used by more packages by itself.
• Moved JSFile into its own package (jsFile.JSFile).
  • moved the JSFilesFromDir method from build/context.go into the jsFile package since it relates to JSFile.
• Moved sources into its own package (sources.Sources) so that it can be used by both the build and compiler packages.
  • split the packageImporter used by Sources into two parts to reduce dependencies:
    • The first became packageImporter that uses errorList to collect any errors that occurred.
    • The second part got added to ImportContext as Import since the cached packages and archives were already on ImportContext.
  • Since ImportContext already had an Import method, I renamed it to ImportArchive so that Import on ImportContext implements go/types.Importer but allows us to still import an archive.
• Moved GoLinkname into its own package (linkname.GoLinkname) so that the sources package can use it.
  • exposed GoLinknameSet and ParseGoLinknames so that they can be used by compiler.
  • moved errorAt into linkname since it was only being used by GoLinkname at this moment.
• Replaced ParsedPackage with Sources since Sources already existed with nearly everything in ParsedPackage.
  • per request in prior ticket (Separate Parsing and Compiling #1361) I renamed the Imports method to UnresolvedImports when moving that method to Sources.
  • added the Dir string and JSFiles []jsFile.JSFile fields that were missing from Sources but needed by ParsedPackage.
  • added some comments to indicate the state of the Sources, e.g. "at this point the sources haven't been sorted".
• I update compiler/package.go#Compile to take the root Sources instead of parts from a ParsedPackage and remove the original creation of the Sources that was done first thing in Compile (after some error handling stuff).