Skip to content

Breakup parseAndAugment method #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nevkontakte merged 1 commit into from
Dec 19, 2023
Merged

Breakup parseAndAugment method #1256

nevkontakte merged 1 commit into from
Dec 19, 2023

Conversation

@grantnelson-wf
Copy link
Collaborator

@grantnelson-wf grantnelson-wf commented Dec 18, 2023 •
edited
Loading

This ticket breaks up the parseAndAugment method into smaller methods which are easier to understand. This also adds unit-tests specifically for the augmentation methods that were extracted from parseAndAugment. This should have no affect on the functionality of parseAndAugment and is purely just reorganization.

parseAndAugment now has the following helper methods:

  • parseOverlayFiles
  • parserOriginalFiles
  • augmentOverlayFile
  • augmentOriginalImports
  • augmentOriginalFile

@grantnelson-wf grantnelson-wf mentioned this pull request Dec 18, 2023
Closed
7 tasks
@grantnelson-wf grantnelson-wf marked this pull request as ready for review December 18, 2023 19:21
@grantnelson-wf grantnelson-wf mentioned this pull request Dec 18, 2023
Merged
@nevkontakte nevkontakte merged commit f34e28b into gopherjs:go1.19 Dec 19, 2023
@grantnelson-wf grantnelson-wf deleted the breakupAugment branch December 29, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nevkontakte nevkontakte nevkontakte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grantnelson-wf @nevkontakte