Skip to content

Conversation

@grantnelson-wf
Copy link
Collaborator

@grantnelson-wf grantnelson-wf commented Dec 18, 2023

This ticket fixes the issue generics was causing in parseAndAugment. The problem was that FuncKey didn't handle *ast.IndexListExpr nor *ast.IndexExpr since those were introduced in function names for generics. This ticket has the following changes:

  • Update FuncKey to handle generics.
  • compiler/natives/src/net/http/http.go imports io/util which is no longer used in original runtime so causes the "extra import tests" in build_test.go to fail, so I also updated it to use io.
  • Minor lint fix for creating an error.

@grantnelson-wf grantnelson-wf marked this pull request as ready for review December 18, 2023 17:37
@nevkontakte nevkontakte merged commit 022eb64 into gopherjs:go1.19 Dec 19, 2023
@grantnelson-wf grantnelson-wf deleted the updateFuncKey branch December 29, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants