Skip to content

nosync: fix build for golang.org/x/tools/internal/tokeninternal #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nevkontakte merged 4 commits into from
Sep 11, 2023
Merged

nosync: fix build for golang.org/x/tools/internal/tokeninternal #1233

nevkontakte merged 4 commits into from
Sep 11, 2023

Conversation

@visualfc
Copy link
Contributor

@visualfc visualfc commented Sep 4, 2023 •
edited
Loading

fix build for golang.org/x/tools/internal/tokeninternal

// require golang.org/x/tools v0.12.1-0.20230901210945-21090a2aa8d3

package main

import (
	_ "golang.org/x/tools/go/gcexportdata"
)
func main() {
}

dump error

../../../go/pkg/mod/golang.org/x/[email protected]/internal/tokeninternal/tokeninternal.go:78:9: invalid array length -delta
 * delta (constant -64 of type int64)

fixed:
Full in size nosync.RWMutex => sync.RWMutex

@visualfc visualfc closed this Sep 4, 2023
@visualfc visualfc reopened this Sep 4, 2023
nevkontakte
nevkontakte approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@nevkontakte nevkontakte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

Could you please re-trigger CircleCI on your branch? Sometime it doesn't report its status to github, unfortunately.

auto-merge was automatically disabled September 6, 2023 02:27

Head branch was pushed to by a user without write access

nevkontakte
nevkontakte reviewed Sep 10, 2023
View reviewed changes
@nevkontakte nevkontakte merged commit c9dc8a9 into gopherjs:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nevkontakte nevkontakte nevkontakte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@visualfc @nevkontakte