natives: duplicate aliasing.go in x/crypto revisted #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as fcd349a. x/crypto internally moved the AnyOverlap from x/crypto/internal/subtle/ to /x/crypto/internal/alias/.
benma
added a commit
to BitBoxSwiss/bitbox02-api-js
that referenced
this pull request
Aug 28, 2023
``` cd gowrapper go get github.com/digitalbitbox/bitbox02-api-go@8aaeb1fdf18ebf6a445f0b68582d9799f00b6793 go mod tidy go mod vendor ``` The /x/crypto transitive dep was updated that broke GopherJS, so we forked it to github.com/digitalbitbox/gopherjs and published the fix at the tag `v1.17.2+go1.17.9-patched`. The patch is a backport of the fix at gopherjs/gopherjs#1227.
Member
|
I believe #1230 will resolve the CI failures, that are unrelated to the changes in this PR. |
nevkontakte
approved these changes
Aug 30, 2023
Member
nevkontakte
left a comment
nevkontakte
left a comment
There was a problem hiding this comment.
We really ought to figure out a better strategy for handing this than cargo-culting this hack. One of those days...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as fcd349a.
x/crypto internally moved the AnyOverlap from
x/crypto/internal/subtle/ to /x/crypto/internal/alias/.