Use esbuild to minify prelude #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

flimzy merged 4 commits into master from esbuild

Jun 14, 2023

Member

flimzy commented Jun 11, 2023

Possible alternative to #1201

This comment has been minimized.

Sign in to view

flimzy force-pushed the esbuild branch from b3b5ea1 to 490b842 Compare

June 11, 2023 20:15

This comment has been minimized.

Sign in to view

flimzy force-pushed the esbuild branch from 490b842 to 106412f Compare

June 11, 2023 20:23

This comment has been minimized.

Sign in to view

flimzy added 2 commits

June 11, 2023 22:47


          Use esbuild to minify prelude


          Enable KeepNames to preserve stack traces

a73a32f

flimzy force-pushed the esbuild branch from 106412f to a73a32f Compare

June 12, 2023 19:48

This comment has been minimized.

Sign in to view

nevkontakte approved these changes

View reviewed changes

compiler/prelude/prelude.go Outdated Show resolved Hide resolved


          Log all minifcation warnings and errors, not just one

5b7f364

This comment has been minimized.

Sign in to view

nevkontakte reviewed

View reviewed changes

compiler/prelude/prelude.go Outdated Show resolved Hide resolved

nevkontakte reviewed

View reviewed changes

compiler/prelude/prelude.go Outdated Show resolved Hide resolved


          Use logrus for minification error logging

be642b6

github-actions bot commented Jun 14, 2023

Reference app: jQuery TodoMVC (acf500a6c32a83d8c4582d967b09a65febf0e120)

BRANCH	ORIGINAL	MINIFIED	COMPRESSED (GZIP)
Pull request (esbuild)	2,948,040 bytes	1,934,883 bytes	382,915 bytes
Target branch (master)	0.00% increase (0 bytes)	0.11% increase (2,131 bytes)	0.15% increase (563 bytes)

#outputSize

flimzy merged commit 997bc99 into master

flimzy deleted the esbuild branch

June 14, 2023 09:25

flimzy mentioned this pull request

Minify Preldue on the fly without uglifyjs #1201

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet