Various standard library and compiler fixes to support Go 1.18 #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corresponding upstream change: golang/go@23832ba. Our implementation is not, in fact, optimized, but at least it is correct.
The JavaScript typed array that backs Go array must be shrunk to match the expected Go type. If this is not done, copying the converted array into an array of the same (expected) size causes a "source too large" runtime exception.
The optimization this package implements relies heavily on finalizers, which GopherJS doesn't support. As such it would create a memory leak rather than an actual optimization. Until we decide that we can use WeakMap API, this package can't be safely supported. The only current use of this package is in the `net/netip` package and this commit adds overlays that replace uses of the intern package with direct use of strings.
In GopherJS this function is a no-op, since we don't have access to low-level memory management. We also have to disable the corresponding test, since it uses unsafe features we don't support.
Apparently, under V8 division by zero literal and by zero assigned to a variable yields bitwise-different values of NaN, which broke some tests in `internal/fuzz`. Using an actual NaN value from the JavaScript runtime fixes the issue. Isolated example: https://jsfiddle.net/j3rtaz0o/1/. Note that Firefox doesn't seem to exhibit this issue.
This package uses generics in its tests, which we currently don't support. This causes the compiler to crash.
Contributor
|
Seems to build & run fine for me, thanks for your work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes resolves most (although not all) standard library test failures found by the CI. The list of changes include:
internal/internoptimization, which relies on unsupported unsafe features.Clone()method.NaNliteral as amath.NaN()return value to address errors in theinternal/fuzzpackage tests.Additionally this PR improves compiler panic handling that helped me debug some of the issues in this PR and temporarily excludes
encoding/xmlpackage from the test set, since it uses generics in tests. The package itself, however, works correctly and we will bring the tests back once generics support is implemented.Updates #1092.