Fix jsFS callback-related crashes #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hehe, I distinctly remember not including this fix into our overlays because there's no way anyone would be using Node 8 these days. Oh well :) Could you please add a brief comment to the if condition about BrowserFS and referencing this PR? Git blame gets difficult to trace after a while and overlay code tends to get updated fairly regularly. Other than that, this change looks good to me. |
Contributor
Author
|
I added an explanatory comment to the code section. |
flimzy
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first fix is also present upstream: see js_fs.go. According to the comment, it is here because Node.js 8
fs.utimes()can call the callback without arguments.The first fix also protects against the BrowserFS project’s almost 50 code locations where a callback is called without arguments:
The second commit is an additional safety against the callback argument being
undefinedinstead ofnull. Again, this happens in the BrowserFS project: FS.close() creates a callback that passes its argument to the GopherJS-provided callback, however since the underlying NoSyncFile.close() callscb()instead ofcb(null), this becomesundefinedback in GopherJS’sfsCall()and the call tomapJSError()will throw.