Skip to content

compiler: fix variadic args not being nil when zero length. #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flimzy merged 5 commits into from
Dec 28, 2021
Merged

compiler: fix variadic args not being nil when zero length. #1096

flimzy merged 5 commits into from
Dec 28, 2021

Conversation

@flimzy
Copy link
Member

@flimzy flimzy commented Dec 28, 2021 •
edited
Loading

This PR is simply a rebase of #807 plus a small patch to work with a modern version of GopherJS.

Fixes #806

@github-actions
Copy link

github-actions bot commented Dec 28, 2021

Reference app: jQuery TodoMVC (acf500a6c32a83d8c4582d967b09a65febf0e120)

BRANCH ORIGINAL MINIFIED COMPRESSED (GZIP)
Pull request (fix_806) 3,198,102 bytes 2,077,342 bytes 393,842 bytes
Target branch (master) 0.00% increase (0 bytes) 0.00% increase (0 bytes) 0.00% increase (0 bytes)

#outputSize

@flimzy flimzy merged commit 103facb into master Dec 28, 2021
@flimzy flimzy mentioned this pull request Dec 28, 2021
Closed
@flimzy flimzy deleted the fix_806 branch December 28, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nevkontakte nevkontakte nevkontakte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Omitted variadic function parameter should be nil

4 participants

@flimzy @nevkontakte @myitcv