Fix a typo in slice-to-array conversion tests. #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the tests that were expecting a panic were using a function literal, but instead of calling it and comparing the result to nil, they were comparing the function itself. This change refactors the test to make such a mistake less likely in future.
nevkontakte
referenced
this pull request
Nov 21, 2021
Conversion is fully supported for slices of numeric types, which is probably the most common use case for this feature judging by the discussion in the proposal. However, it is only partially supported for slices of complex types (e.g. strings), since they are backed by the JavaScript's built-in Array type, which lacks ability to share backing memory among subarrays. Conversion works in cases when the slice is converted into array that exactly matches the slice's underlying array, but panics if we are trying to convert a subslice. I feel like an explicit failure is better than a chance of introducing subtle bugs. It also seems that GopherJS internally doesn't really distinguish between array types and pointer to array types, which makes the whole implementation somewhat messy when it comes to nil vs non-nil pointers to arrays. Last but not least, I've moved pointer cache for numeric arrays into the backing ArrayBuffer, which ensures that pointers are comparable between different subarrays.
flimzy
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the tests that were expecting a panic were using a function
literal, but instead of calling it and comparing the result to nil, they
were comparing the function itself.
This change refactors the test to make such a mistake less likely in
future.
Kudos to @dominikh for spotting the bug!