Improve temporary file management in gopherjs test.
#1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include Go package name in the temp file name.
- Close file handle to the temp file early, since we are not actually
using it.
- Clean the temporary file up after test execution finished to reduce
the clutter in the current directory.
I was also going to move temporary files into the OS's temp directory,
but it turns out using current directory is deliberate:
gopherjs#303.
flimzy
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using it.
the clutter in the current directory.
I was also going to move temporary files into the OS's temp directory,
but it turns out using current directory is deliberate:
#303.