Address remaining code review comments.

dmitshur · dmitshur · commit 2587a1cd5553 · 2017-07-25T15:40:06.000-04:00
diff --git a/circle.yml b/circle.yml
@@ -128,3 +128,4 @@ test:
       unicode/utf16
       unicode/utf8
     - go test -v -race ./...
+    - gopherjs test -v --minify fmt # Minification should work.
diff --git a/compiler/natives/src/os/signal/signal.go b/compiler/natives/src/os/signal/signal.go
@@ -3,7 +3,6 @@
 package signal
 
 // Package signal is not implemented for GOARCH=js.
-// TODO: Implement if possible.
 
 func signal_disable(uint32) {}
 func signal_enable(uint32)  {}
diff --git a/compiler/natives/src/reflect/reflect.go b/compiler/natives/src/reflect/reflect.go
@@ -497,7 +497,6 @@ func makechan(typ *rtype, size uint64) (ch unsafe.Pointer) {
 }
 
 func makemap(t *rtype, cap int) (m unsafe.Pointer) {
-	// TODO: Use cap if needed/possible.
 	return unsafe.Pointer(js.Global.Get("Object").New().Unsafe())
 }
 
diff --git a/compiler/natives/src/sync/sync.go b/compiler/natives/src/sync/sync.go
@@ -20,12 +20,7 @@ func runtime_Semacquire(s *uint32) {
 // TODO: Investigate this. If it's possible to implement, consider doing so, otherwise remove this comment.
 func runtime_SemacquireMutex(s *uint32, lifo bool) {
 	// TODO: Use lifo if needed/possible.
-	if *s == 0 {
-		ch := make(chan bool)
-		semWaiters[s] = append(semWaiters[s], ch)
-		<-ch
-	}
-	*s--
+	runtime_Semacquire(s)
 }
 
 func runtime_Semrelease(s *uint32, handoff bool) {
diff --git a/compiler/natives/src/testing/testing.go b/compiler/natives/src/testing/testing.go
@@ -4,5 +4,5 @@ package testing
 
 func callerName(skip int) string {
 	// TODO: Implement if possible.
-	return "caller"
+	return "<unknown>"
 }

Original file line number	Diff line number	Diff line change
`@@ -497,7 +497,6 @@ func makechan(typ *rtype, size uint64) (ch unsafe.Pointer) {`
`497`	`497`	`}`
`498`	`498`
`499`	`499`	`func makemap(t *rtype, cap int) (m unsafe.Pointer) {`
`500`		`- // TODO: Use cap if needed/possible.`
`501`	`500`	`return unsafe.Pointer(js.Global.Get("Object").New().Unsafe())`
`502`	`501`	`}`
`503`	`502`
Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,5 @@ package testing`
`4`	`4`
`5`	`5`	`func callerName(skip int) string {`
`6`	`6`	`// TODO: Implement if possible.`
`7`		`- return "caller"`
	`7`	`+ return "<unknown>"`
`8`	`8`	`}`