just converted some of the travis checks into Github ones. gonna close and reopen this to trigger it :)

@mosajjal 👍 no worries

looks good and doesn't break any existing code. However, it doesn't look like it has any tests. If you have any tests ready to commit that'd be good.

There was no tests in the original PR but i can try add something. What you be a good test, parse some minimal sll2 pcap test file?

take a look at layers tests like dns. For the sake of consistency we can dump the pcap into bytes for testing purposes. makes it easier imo

Added a test case but only included bytes from sll2 and down, looked like other tests only tested from their layer and down.

Yep I gather it's the same. looks good to me :) merged

Confused, what is this about Go code is not formatted, run 'go fmt github.com/google/stenographer/...? should say go fmt ./...?

A did a fmt and lots of things changed... but i gess you have a PR for this?

@mosajjal Aha, good thanks!

yep that's an old relic from the Google's repo and Travis CI stuff. hopefully all will get removed in a couple days :)

👍 Great, and thanks for picking up the gopacket development again!