Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents an automated release of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
=======================================
Coverage 69.00% 69.00%
=======================================
Files 42 42
Lines 19371 19371
=======================================
Hits 13367 13367
Misses 6004 6004 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the @googleworkspace/cli project version from 0.18.1 to 0.18.2. The primary change addresses an authentication error propagation issue, ensuring that errors during token directory creation or permission setting are properly handled. This update also includes several dependency bumps in Cargo.lock (e.g., iri-string, itoa, rustls-webpki, zerocopy) and an update to the nixpkgs lock file in flake.lock. There is no feedback to provide as no review comments were made.
61389be to
0a6c1c5
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the @googleworkspace/cli package and the gws Rust crate to version 0.18.2. It includes two key fixes: addressing a mask_secret panic with multi-byte UTF-8 secrets by using character-based indexing, and improving authentication error propagation to prevent silent failures during token directory operations. Additionally, several Rust dependencies (iri-string, itoa, rustls-webpki, zerocopy, zerocopy-derive) and the Nix package set (nixpkgs) have been updated. There is no feedback to provide on the review comments as none were submitted.
0a6c1c5 to
dbeb6fa
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the @googleworkspace/cli to version 0.18.2. Key changes include fixing a panic when masking multi-byte UTF-8 secrets, improving the gws auth setup command to handle --help before launching the wizard, and ensuring proper propagation of authentication errors. Additionally, several Rust dependencies have been updated, and the Nix flake inputs have been refreshed. I have no feedback to provide.
dbeb6fa to
2aa0521
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request prepares the release of version 0.19.0. The changes consist of version bumps in Cargo.toml, Cargo.lock, and package.json, and an update to CHANGELOG.md with the latest changes from the now-removed changeset files. These modifications are all standard and correct for a release process. I have reviewed the changes and have no suggestions for improvement.
2aa0521 to
896bec8
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request, generated by the Changesets release action, prepares version 0.19.0 for release. The changes primarily consist of version bumps in Cargo.toml, package.json, and Cargo.lock, along with the corresponding CHANGELOG.md update. Additionally, it includes a formatting fix across all SKILL.md files, converting YAML flow sequences to block sequences to ensure compatibility with strictyaml. The changes are consistent and appropriate for a release. I find no issues in this pull request.
6f788a7 to
fc0f2e5
Compare
e249930 to
a03b3ad
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request automates the release of version 0.19.0. The changes include updating the changelog, bumping version numbers in configuration files, and modifying YAML frontmatter in skill documentation for compatibility. All changes appear to be correct and consistent with the goal of this release. I have not identified any issues.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@googleworkspace/[email protected]
Minor Changes
a078945: Refactor all
gws authsubcommands to use clap for argument parsingReplace manual argument parsing in
handle_auth_command,handle_login,resolve_scopes, andhandle_exportwith structuredclap::Commanddefinitions. IntroducesScopeModeenum for type-safe scope selection and adds proper--helpsupport for all auth subcommands.Patch Changes
8a749c2: feat(helpers): add --dry-run support to events helper commands
Add dry-run mode to
gws events +renewandgws events +subscribecommands.When --dry-run is specified, the commands will print what actions would be
taken without making any API calls. This allows agents to simulate requests
and learn without reaching the server.
d679401: Fix
mask_secretpanic on multi-byte UTF-8 secrets by using char-based indexing instead of byte-offset slicingd341de2: Handle --help/-h in
gws auth setupbefore launching the setup wizard, preventing accidental project creation when users just want usage infof157208: fix: use block-style YAML sequences in generated SKILL.md frontmatter
Replace flow sequences (
bins: ["gws"],skills: [...]) with block-stylesequences (
bins:\n - gws) in all generated SKILL.md frontmatter templates.Flow sequences are valid YAML but rejected by
strictyaml, which theAgent Skills reference implementation (
agentskills validate) uses to parsefrontmatter. This caused all 93 generated skills to fail validation.
Fixes SKILL.md frontmatter uses flow sequences which fail
agentskills validate#521b4d5e26: Fix auth error propagation: properly propagate errors when token directory creation or permission setting fails, instead of silently ignoring them