fix: fixed InfoWindow creation in KmlParser #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code Coverage
|
dkhawk
reviewed
Nov 4, 2025
|
|
||
| public View getInfoContents(@NonNull Marker arg0) { | ||
| @Override | ||
| public View getInfoContents(@NonNull Marker marker) { |
Contributor
There was a problem hiding this comment.
Slightly cleaner:
@Override
public View getInfoContents(@NonNull Marker marker) {
String title = marker.getTitle();
if (title == null) {
return null;
}
View view = LayoutInflater.from(mContext).inflate(R.layout.amu_info_window, null);
TextView infoWindowText = view.findViewById(R.id.window);
StringBuilder infoText = new StringBuilder(title);
String snippet = marker.getSnippet();
if (snippet != null) {
infoText.append("<br>").append(snippet);
}
infoWindowText.setText(Html.fromHtml(infoText.toString()));
return view;
}
dkhawk
approved these changes
Nov 4, 2025
googlemaps-bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
## [3.19.1](v3.19.0...v3.19.1) (2025-11-04) ### Bug Fixes * fixed InfoWindow creation in KmlParser ([#1624](#1624)) ([d74757c](d74757c))
Contributor
|
🎉 This PR is included in version 3.19.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
dkhawk
pushed a commit
that referenced
this pull request
Nov 12, 2025
## [3.19.1](v3.19.0...v3.19.1) (2025-11-04) ### Bug Fixes * fixed InfoWindow creation in KmlParser ([#1624](#1624)) ([d74757c](d74757c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue on the InfoWindow creation with the KmlParser.
The InfoWindow was being created so far if the Markers had no title or snippet. In this case, the InfoWindow cannot be created.
Fixes #1623