Skip to content

Conversation

@dkhawk
Copy link
Contributor

@dkhawk dkhawk commented Aug 27, 2025

This commit implements edge-to-edge UI for the demo application. Changes include: - Updating the app theme to be edge-to-edge. - Applying window insets to the base and main activities. - Adding a separate styles.xml for API 27+ to handle display cutouts.

@dkhawk dkhawk requested a review from kikoso August 27, 2025 18:20
@dkhawk dkhawk changed the title feat: Implement edge-to-edge UI chore: Implement edge-to-edge UI Aug 27, 2025
@googlemaps-bot
Copy link
Contributor

googlemaps-bot commented Aug 27, 2025

Code Coverage

Overall Project 40.25% -0.01% 🍏
Files changed 88.46% 🍏

File Coverage
HeatmapTileProvider.kt 81.27% -0.19% 🍏

@dkhawk dkhawk force-pushed the fix/edge-to-edge-ui branch from 4836b9b to 03d7f44 Compare August 27, 2025 18:28
dkhawk added 11 commits August 28, 2025 10:32
The `@Deprecated` annotation has been updated to the Kotlin syntax and now includes a `ReplaceWith` expression to provide IDE quick-fix support.

Additionally, new unit tests using Google Truth have been added for the `Point` class to verify its construction and inheritance.
This commit migrates the `Gradient` and `WeightedLatLng` classes and their corresponding tests from Java to idiomatic Kotlin.

This conversion is part of the larger effort to modernize the library and prepare it for Kotlin Multiplatform (KMP) compatibility.

Key changes include:
- `WeightedLatLng` is now a `data class` with a private primary constructor to ensure correct instantiation while providing the benefits of auto-generated methods. The `@ExposedCopyVisibility` annotation has been added to maintain binary compatibility for the `copy()` method.
- `Gradient` has been converted to a Kotlin class, using `@JvmOverloads` for constructor compatibility and a `companion object` for its static helper method.
- The `internal` visibility of a method in `Gradient` was changed to `public` to ensure visibility to Java classes during the mixed-language phase of the migration.
- Unit tests for both classes have been ported to Kotlin, using the Truth assertion framework.
This commit completes the migration of the `heatmaps` package to Kotlin by porting the final and most complex class, `HeatmapTileProvider`.

This conversion modernizes the class by introducing several idiomatic Kotlin features and improves its design by refactoring a key data structure.

Key changes include:
- The `HeatmapTileProvider` and its `Builder` are now written in Kotlin.
- The `getMaxValue()` method was refactored to use a `Map` with a type-safe `Vector` key instead of the Android-specific `LongSparseArray`, improving readability and moving closer to KMP compatibility.
- A new test suite was created from scratch for the provider, as none existed previously. This improves the code coverage and reliability of the module.
- Necessary adjustments were made to the demo application to support the newly ported Kotlin class.
Updates the copyright headers in the test files that were created
during the Kotlin porting process.

- Corrects the copyright year to 2025.
- Corrects the company name from "Google Inc." to "Google LLC".
Updates the copyright headers in the `heatmaps` package source and test files.

- Corrects the copyright year to 2025.
- Corrects the company name from "Google Inc." to "Google LLC".
This commit implements edge-to-edge UI for the demo application.

Changes include:
- Updating the app theme to be edge-to-edge.
- Applying window insets to the base and main activities.
- Adding a separate styles.xml for API 27+ to handle display cutouts.
This commit updates the copyright headers in the following files:
- demo/build.gradle.kts
- demo/src/main/java/com/google/maps/android/utils/demo/BaseDemoActivity.java
- demo/src/main/java/com/google/maps/android/utils/demo/MainActivity.java
- demo/src/main/res/values/styles.xml
- demo/src/main/res/values-v27/styles.xml
@dkhawk dkhawk force-pushed the fix/edge-to-edge-ui branch from ff5b8f3 to 4afaedd Compare August 28, 2025 16:32
dkhawk added 4 commits August 28, 2025 10:50
….Builder

This commit replaces the `check` function with `require` for validating input data in the `HeatmapTileProvider.Builder`.

Using `require` is more idiomatic for precondition checks, throwing an `IllegalArgumentException` which is more appropriate in this context than the `IllegalStateException` thrown by `check`.
This commit updates `HeatmapTileProviderTest` to expect an `IllegalArgumentException` instead of `IllegalStateException` when building a provider with no data. It also cleans up unused exception variables in catch blocks.
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small step for humankind, one big step for edge-to-edge users

@dkhawk dkhawk merged commit f005d29 into main Aug 28, 2025
8 checks passed
@dkhawk dkhawk deleted the fix/edge-to-edge-ui branch August 28, 2025 18:32
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 3.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants