build: Port geometry and quadtree packages to Kotlin #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the `PointQuadTree` class and its corresponding test, `PointQuadTreeTest`, from Java to idiomatic Kotlin. This conversion modernizes the codebase, improving its conciseness, readability, and null safety. The key changes are: - **`PointQuadTree` to Kotlin**: The core `PointQuadTree` class has been rewritten in Kotlin, leveraging features like primary constructors, companion objects, and stricter nullability. - **`PointQuadTreeTest` to Kotlin**: The associated test class has also been ported to Kotlin, resulting in more streamlined test code. - **Copyright Header Update**: The copyright year has been updated in the converted files.
This commit modernizes the `Point` and `Bounds` classes by converting them from Java to idiomatic Kotlin. This change improves code conciseness, readability, and null safety. Key changes include: - The `Point` and `Bounds` classes are now written in Kotlin. - `@JvmField` annotations are used on properties to maintain binary compatibility for Java consumers. - New unit tests, `PointTest.kt` and `BoundsTest.kt`, have been added to ensure the correctness of the ported classes.
Contributor
Code Coverage
|
Collaborator
|
Generally thinking: this would release a new version. I don't think this is intrinsically wrong, but wondering if we should instead annotate it with the prefix build" until we have more code written in Kotlin. |
dkhawk
changed the title
Contributor
|
🎉 This PR is included in version 3.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 3.16.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the
quadtreeandgeometrypackages from Java to modern, idiomatic Kotlin.Key Changes:
PointQuadTreeto Kotlin: The corePointQuadTreeclass and its tests have been rewritten in Kotlin, improving conciseness and null safety.PointandBoundsto Kotlin: The fundamentalPointandBoundsclasses in thegeometrypackage have been ported to Kotlin.@JvmFieldand anopen classwith a manualcopy()implementation forPoint.PointandBounds, which previously had no dedicated test coverage.Verification:
This work modernizes key, platform-independent parts of the library and sets a strong foundation for future Kotlin migrations.