Fix/always dispose on main thread #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t running on non-main thread in instrumented test)
Contributor
|
🎉 This PR is included in version 6.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #211, I found that composition.dispose() inside launchSubcomposition(...) must run on the main thread. In instrumented tests, it can be run on other threads, causing crashes because Google Maps couldn't dispose correctly.
To fix this, I've set the launch command within launchSubcomposition to always run on the main thread.
You can reproduce this issue from the https://github.com/akexorcist/maps-compose-ui-test-issue
Fixes #211 🦕