fix: install doc uploader and releasetool with hashes#227
Merged
gcf-merge-on-green[bot] merged 2 commits intomainfrom Aug 22, 2022
Merged
fix: install doc uploader and releasetool with hashes#227gcf-merge-on-green[bot] merged 2 commits intomainfrom
gcf-merge-on-green[bot] merged 2 commits intomainfrom
Conversation
Hashes ensure we're always running a known version. Installing them in the docker image means the publish and release scripts don't need to install them with a pip command.
chingor13
approved these changes
Aug 22, 2022
SurferJeffAtGoogle
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
SurferJeffAtGoogle
added a commit
to SurferJeffAtGoogle/synthtool
that referenced
this pull request
Aug 22, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227
SurferJeffAtGoogle
added a commit
to googleapis/synthtool
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227
gcf-owl-bot bot
added a commit
to googleapis/cloud-debug-nodejs
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 Source-Link: googleapis/synthtool@ab7384e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
gcf-owl-bot bot
added a commit
to googleapis/gcs-resumable-upload
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 Source-Link: googleapis/synthtool@ab7384e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
gcf-owl-bot bot
added a commit
to googleapis/cloud-profiler-nodejs
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 Source-Link: googleapis/synthtool@ab7384e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
This was referenced Aug 23, 2022
gcf-owl-bot bot
added a commit
to googleapis/cloud-trace-nodejs
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 Source-Link: googleapis/synthtool@ab7384e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
gcf-owl-bot bot
added a commit
to googleapis/gaxios
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 Source-Link: googleapis/synthtool@ab7384e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
gcf-owl-bot bot
added a commit
to googleapis/gax-nodejs
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 Source-Link: googleapis/synthtool@ab7384e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
gcf-owl-bot bot
added a commit
to googleapis/gcp-metadata
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 Source-Link: googleapis/synthtool@ab7384e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
This was referenced Aug 23, 2022
gcf-owl-bot bot
added a commit
to googleapis/github-repo-automation
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 Source-Link: googleapis/synthtool@ab7384e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
gcf-owl-bot bot
added a commit
to googleapis/code-suggester
that referenced
this pull request
Aug 23, 2022
because the tools are already installed in the docker image as of googleapis/testing-infra-docker#227 Source-Link: googleapis/synthtool@ab7384e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:bb493bf01d28519e82ab61c490c20122c85a7119c03a978ad0c34b4239fbad15
This was referenced Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hashes ensure we're always running a known version.
Installing them in the docker image means the publish and release scripts don't need to install them with a pip command.