chore: remove leading newline from LICENSE#938
Merged
JustinBeckwith merged 3 commits intomasterfrom Feb 3, 2021
Merged
Conversation
google-cla
Bot
added
the
cla: yes
SurferJeffAtGoogle
approved these changes
Feb 3, 2021
crwilcox
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to GitHub support, our Java repositories aren't detected as Apache-2.0 in their tooling due to the newline at the beginning of our LICENSE files:
https://github.com/googleapis/java-firestore/blob/master/LICENSE
This is annoying, but should get the GitHub API (and the UI) to report the correct license type.