docs: add instructions for authenticating for system tests#872
Merged
docs: add instructions for authenticating for system tests#872
Conversation
google-cla
Bot
added
the
cla: yes
JustinBeckwith
approved these changes
Dec 7, 2020
bcoe
added
the
do not merge
bcoe
approved these changes
Dec 8, 2020
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
This is looking good to me, mind running synthtool against one repo manually first, so we can make sure it looks right?
Contributor
Author
|
Can confirm it looks right! Also added in a fix to this: #431 |
bcoe
approved these changes
Dec 21, 2020
bcoe
removed
the
do not merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this docs question: googleapis/nodejs-googleapis-common#327
We need to add authentication instructions when running system tests as well - these docs add to that.