Skip to content

chore: Update publish_javadoc.sh#864

Merged
lesv merged 4 commits intomasterfrom
lesv-patch-1
Dec 7, 2020
Merged

chore: Update publish_javadoc.sh#864
lesv merged 4 commits intomasterfrom
lesv-patch-1

Conversation

@lesv
Copy link
Copy Markdown
Contributor

@lesv lesv commented Dec 1, 2020

  • add export to the envVar's to make sure maven knows about them.
  • report the Java version

@tbpg FYI

* add `export` to the envVar's to make sure maven knows about them.
* report the Java version
@lesv lesv requested review from a team and chingor13 December 1, 2020 02:43
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2020
@lesv lesv changed the title (chore): Update publish_javadoc.sh chore: Update publish_javadoc.sh Dec 1, 2020

popd

# V2 currently requires Java 8 ONLY.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check for Java 8 instead of printing the version?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? It's just there to remind someone when they run across a problem.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

* remove `java -version`
popd

# V2
# V2 due to problems w/ the released javadoc plugin doclava, Java 8 is required. Beware of accidental updates.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be locking the version of the plugin in the pom.xml then?

Is "doclava" correct?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done. DocLava hasn't been published (by us) in 6 years. I'm trying to get this released so we can the CloudRAD done. We are also working on a replacement.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I just never encountered that before. I'm still having trouble parsing this comment. It might be worth rewriting.

popd

# V2
# V2 due to problems w/ the released javadoc plugin doclava, Java 8 is required. Beware of accidental updates.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I just never encountered that before. I'm still having trouble parsing this comment. It might be worth rewriting.

@lesv lesv merged commit 5d11bd2 into master Dec 7, 2020
@lesv lesv deleted the lesv-patch-1 branch December 7, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants