Skip to content

fix(java_library): Update publish_javadoc.sh#819

Merged
lesv merged 2 commits intomasterfrom
lesv-patch-1
Oct 22, 2020
Merged

fix(java_library): Update publish_javadoc.sh#819
lesv merged 2 commits intomasterfrom
lesv-patch-1

Conversation

@lesv
Copy link
Copy Markdown
Contributor

@lesv lesv commented Oct 19, 2020

Upload from target/devsite/reference not target/devsite.

@tbpg FYI

@lesv
Update publish_javadoc.sh
9a8c65d 
We don't want quite as much and need to be in `target/devsite/reference`.
@lesv lesv requested review from a team and chingor13 October 19, 2020 23:56
chingor13
chingor13 approved these changes Oct 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this merges as a "chore". Fix will tell the client library to ship a new patch version

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2020
@lesv lesv merged commit 9593c3b into master Oct 22, 2020
@lesv
Copy link
Copy Markdown
Contributor Author

lesv commented Oct 22, 2020

@chingor13 Sigh - just saw your comment about chore vs. fix - sigh / sorry.

@lesv lesv deleted the lesv-patch-1 branch October 22, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lesv @chingor13