Skip to content

chore(docs): update code of conduct of synthtool and templates#808

Merged
crwilcox merged 8 commits intomasterfrom
update-code-of-conduct
Oct 22, 2020
Merged

chore(docs): update code of conduct of synthtool and templates#808
crwilcox merged 8 commits intomasterfrom
update-code-of-conduct

Conversation

@crwilcox
Copy link
Copy Markdown
Contributor

@crwilcox crwilcox requested review from a team October 15, 2020 15:38
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@crwilcox
Copy link
Copy Markdown
Contributor Author

Figured out why I didn't see project stewards. The Open Source Program has modified 1.4 slightly. Change coming.

@crwilcox crwilcox requested a review from a team October 15, 2020 15:53
Copy link
Copy Markdown

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it these templates are pushed automatically when a new project is created? Consider (for a future PR): maybe the tool can ask for a steward, update the template when the project is created, and push the code of conduct file with a name already filled out.

Comment thread CODE_OF_CONDUCT.md Outdated
behavior is threatening or harassing, report it. We are dedicated to providing
an environment where participants feel welcome and safe.

Reports should be directed to *[PROJECT STEWARD NAME(s) AND EMAIL(s)]*, the
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are supposed to name a steward for this project, and put their name and email here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coryan . We are chatting as a team how to manage this (if we want it to be the same across all libraries in a project or if we should support templating)

@crwilcox
Copy link
Copy Markdown
Contributor Author

This is ready for review, files have had string placeholders replaced.

@bcoe bcoe changed the title feat: update code of conduct of synthtool and templates docs: update code of conduct of synthtool and templates Oct 15, 2020
@SurferJeffAtGoogle
Copy link
Copy Markdown
Contributor

@chingor13, this PR needs an approval from googleapis/yoshi-java.

@crwilcox crwilcox changed the title docs: update code of conduct of synthtool and templates chore(docs): update code of conduct of synthtool and templates Oct 22, 2020
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 22, 2020
@crwilcox crwilcox merged commit 5f6ef0e into master Oct 22, 2020
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 22, 2020
@chingor13 chingor13 deleted the update-code-of-conduct branch October 22, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants