chore(java): use separate autosynth job for README#767
Merged
gcf-merge-on-green[bot] merged 9 commits intogoogleapis:masterfrom Sep 29, 2020
Merged
chore(java): use separate autosynth job for README#767gcf-merge-on-green[bot] merged 9 commits intogoogleapis:masterfrom
gcf-merge-on-green[bot] merged 9 commits intogoogleapis:masterfrom
Conversation
google-cla
Bot
added
the
cla: yes
chingor13
commented
Sep 21, 2020
|
|
||
| # README.md is now synthesized separately. This prevents synthtool from deleting the | ||
| # README as it's no longer generated here. | ||
| excludes.append("README.md") |
Contributor
Author
There was a problem hiding this comment.
This prevents synthtool from removing the README.
chingor13
commented
Sep 22, 2020
Comment on lines
+377
to
+381
| if ( | ||
| not toolbox.metadata_contains_generated_files(toolbox.branch) | ||
| and toolbox.metadata_contains_generated_files(toolbox.sub_branch(youngest)) | ||
| and not change_pusher.check_if_pr_already_exists(toolbox.branch) | ||
| ): |
Contributor
Author
There was a problem hiding this comment.
Running nox locally made this change on my machine. It still seems to pass tests.
SurferJeffAtGoogle
suggested changes
Sep 22, 2020
| echo "https://${GITHUB_TOKEN}:@github.com" >> ~/.git-credentials | ||
| git config --global credential.helper 'store --file ~/.git-credentials' | ||
|
|
||
| python3.6 -m pip install git+https://github.com/googleapis/synthtool.git#egg=gcp-synthtool |
Contributor
There was a problem hiding this comment.
What does #egg= do?
Contributor
Author
There was a problem hiding this comment.
It's used to specify the name of the library being installed: https://pip.pypa.io/en/stable/reference/pip_install/#working-out-the-name-and-version
Contributor
|
Please trigger a kokoro build with these changes and link to the result. |
Contributor
Author
|
I need to run this from a fork because autosynth assumes that we run from the default branch.
Opened #773 as a feature request to make testing something like this easier. |
stephaniewang526
approved these changes
Sep 24, 2020
SurferJeffAtGoogle
approved these changes
Sep 29, 2020
chingor13
added
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split java README generation into a separate, per-repo continuous job running from Kokoro.
We now generate a new job that runs on commits to the primary branch that strictly manages the README.md. This should prevent us from seeing the contextless autosynth PRs which are caused by non-proto/template upstream changes.