Skip to content

feat(python-library): changes to docs job#707

Merged
tmatsuo merged 9 commits intogoogleapis:masterfrom
tmatsuo:python-docfx
Jul 30, 2020
Merged

feat(python-library): changes to docs job#707
tmatsuo merged 9 commits intogoogleapis:masterfrom
tmatsuo:python-docfx

Conversation

@tmatsuo
Copy link
Copy Markdown
Contributor

@tmatsuo tmatsuo commented Jul 30, 2020

This is another trial of #700

  • add a test that fails
  • make the test pass

Takashi Matsuo added 3 commits July 30, 2020 16:53
* migrate to Trampoline V2
* add docs-presubmit job
* create docfx yaml files and upload them to another bucket
@tmatsuo tmatsuo requested a review from busunkim96 July 30, 2020 18:37
@tmatsuo tmatsuo requested a review from a team July 30, 2020 18:37
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2020
@tmatsuo tmatsuo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 30, 2020
@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Jul 30, 2020

The build failed as expected:

E   jinja2.exceptions.TemplateSyntaxError: Missing end of comment tag

@tmatsuo tmatsuo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 30, 2020
Comment thread synthtool/gcp/common.py Outdated
@tmatsuo tmatsuo merged commit 5dfda56 into googleapis:master Jul 30, 2020
@tmatsuo tmatsuo deleted the python-docfx branch July 30, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants