chore: add config files for cloud-rad for node.js#667
Merged
SurferJeffAtGoogle merged 3 commits intomasterfrom Jul 16, 2020
Merged
chore: add config files for cloud-rad for node.js#667SurferJeffAtGoogle merged 3 commits intomasterfrom
SurferJeffAtGoogle merged 3 commits intomasterfrom
Conversation
Generate and upload yaml files for ref docs
googlebot
added
the
cla: yes
bcoe
reviewed
Jul 15, 2020
| { | ||
| "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json", | ||
|
|
||
| /** |
There was a problem hiding this comment.
should this be a .js file, seems to be very angry about the comments in the JSON.
Contributor
Author
There was a problem hiding this comment.
It's supposed to be a json file, generated by api-extactor. I added a .gitattributes file instead so it looks less angry.
tbpg
approved these changes
Jul 15, 2020
tbpg
left a comment
tbpg
left a comment
There was a problem hiding this comment.
Woohoo! LGTM after the JSON comment issue.
fhinkel
force-pushed
the
cloud-rad
branch
4 times, most recently
from
69a2346 to
cc11319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate and upload yaml files for ref docs.