build: --credential-file-override is no longer required#632
Merged
gcf-merge-on-green[bot] merged 6 commits intomasterfrom Aug 8, 2020
Merged
build: --credential-file-override is no longer required#632gcf-merge-on-green[bot] merged 6 commits intomasterfrom
gcf-merge-on-green[bot] merged 6 commits intomasterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
|
Our CI runners run on GCE instances - which have a metadata server. Without the credentials file, we rely on ADC and these servers have an associated service account. |
chingor13
approved these changes
Jun 19, 2020
SurferJeffAtGoogle
approved these changes
Jun 19, 2020
bcoe
added
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chingor13 has configured our runtime environment, such that we no longer need to explicitly provide a credentials file.
How does this magic work, I didn't fully understand?