Skip to content

fix: update node issue template#582

Merged
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
stephenplusplus:spp--template
Jun 17, 2020
Merged

fix: update node issue template#582
JustinBeckwith merged 4 commits intogoogleapis:masterfrom
stephenplusplus:spp--template

Conversation

@stephenplusplus
Copy link
Copy Markdown
Contributor

@stephenplusplus stephenplusplus commented May 28, 2020

We frequently see issues where users are having a problem with the product as opposed to the client library itself. We end up wasting their time before coming to the conclusion "it's not us, it's them". I've updated the messaging in the issue template to promote self-diagnostics in the hope the user ultimately asks the right team only once.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
Comment thread synthtool/gcp/templates/node_library/.github/ISSUE_TEMPLATE/bug_report.md Outdated
@stephenplusplus stephenplusplus marked this pull request as ready for review June 16, 2020 14:20
@stephenplusplus
Copy link
Copy Markdown
Contributor Author

cc @JustinBeckwith @bcoe

Copy link
Copy Markdown
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a fair bit of evidence that folks entirely ignore these templates, but it doesn't hurt to try!


Please run down the following list and make sure you've tried the usual "quick fixes":
1) Is this a client library issue or a product issue?
This is the client library for {{metadata['product']}}. We will only be able to assist with issues that pertain to the behaviors of this library. If the issue you're experiencing is due to the behavior of the product itself, please visit [{{metadata['product']}} Support page]({{metadata['product-url']}}/docs/getting-support) to reach the most relevant engineers.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, you can see what's available here:
https://github.com/googleapis/google-cloud-node/blob/master/libraries.json

You probably want:

  • product => name_pretty
  • product-url => product_documentation

In some cases we also have a link to the product issue tracker via issue_tracker. I would double check that value is available on a library by library basis before using it though.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice. I sent a PR (that this PR now depends on): googleapis/google-cloud-node#3008

@stephenplusplus
Copy link
Copy Markdown
Contributor Author

@JustinBeckwith googleapis/google-cloud-node#3008 merged which added a new property "support_documentation" to libraries.json. This PR was updated with your feedback and to make use of that new property. PTAL!

@stephenplusplus
Copy link
Copy Markdown
Contributor Author

P.S. I have no merge rights here :)

@JustinBeckwith JustinBeckwith merged commit b10590a into googleapis:master Jun 17, 2020
@stephenplusplus stephenplusplus deleted the spp--template branch June 17, 2020 21:06
@stephenplusplus
Copy link
Copy Markdown
Contributor Author

@JustinBeckwith Uh oh! The placeholders aren't replaced: https://github.com/googleapis/nodejs-datastore/issues/new?template=bug_report.md

This is the client library for .

and

...please visit the [ Support page]()...

@JustinBeckwith
Copy link
Copy Markdown
Contributor

wibble

@JustinBeckwith
Copy link
Copy Markdown
Contributor

I kind of figured you had tested this locally with synthtool 🐸 Mind working through the instructions here to get it running locally:
https://github.com/googleapis/synthtool/tree/master/synthtool

If you need help figuring out what's up, @bcoe is probably your best bet :)

@stephenplusplus
Copy link
Copy Markdown
Contributor Author

Thanks, I have made a discovery while testing with Storage... the placeholders are from the package.json inside of the client library. .repo-metadata.json contains many of the same fields as libraries.json, but not all, but still the templating step doesn't pull from there.

For now, should we just roll this PR back? Figure out how to sync .repo-metadata.json with libraries.json's repo description, and then have the templating step pull from that file?

@stephenplusplus
Copy link
Copy Markdown
Contributor Author

stephenplusplus commented Jun 22, 2020

@bcoe how do you think we should proceed?

Where we are now:

  • Many PRs have been merged across the client libraries that have blank placeholders in their bug report templates, e.g. "This is the client library for ."

How we got here:

Where we can go:

  1. Add support in this repo for using variables found in ".repo-metadata.json"
  2. Roll back this PR and consider this change again some day in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants