build(java): set GOOGLE_CLOUD_PROJECT env for samples/integration tests#484
Merged
chingor13 merged 3 commits intogoogleapis:masterfrom Apr 13, 2020
Merged
build(java): set GOOGLE_CLOUD_PROJECT env for samples/integration tests#484chingor13 merged 3 commits intogoogleapis:masterfrom
chingor13 merged 3 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
stephaniewang526
approved these changes
Apr 13, 2020
JustinBeckwith
approved these changes
Apr 13, 2020
|
|
||
| env_vars: { | ||
| key: "GOOGLE_APPLICATION_CREDENTIALS" | ||
| value: "keystore/73713_java_it_service_account" |
There was a problem hiding this comment.
I have no idea how keystore works. Does this service account include the permission to java-docs-samples-testing project? or Does this have to be updated?
Contributor
Author
There was a problem hiding this comment.
It does for some APIs which we will need to grant permissions for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #483