chore(python): conditionally load credentials in .kokoro/build.sh#2055
Merged
chore(python): conditionally load credentials in .kokoro/build.sh#2055
Conversation
parthea
approved these changes
Feb 21, 2025
parthea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the
build.shfile to only load the credentials if they are present. With our new instances, we will rely on ADC and environment variables to configure auth for tests rather than exported service account keys.This allows the presubmit to run on both our old Kokoro infra and new Kokoro infra.
See googleapis/python-bigquery#2120 for example of the tests working on both legacy and new infra in parallel.