Conversation
b1b7063 to
29877cd
Compare
ohmayr
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs build is failing with error
ERROR: Could not open requirements file: [Errno 2] No such file or directory: '/workspace/.kokoro/requirements.txt'. The root of the problem is that this file was deleted in #2035. It turns out that this line was obsolete, because there is already a requirements file here.I also needed to add the dependency
gcp-docuploaderto resolve the/usr/local/bin/python3.10: No module named docuploadererror during the upload stepI also updated the dependencies in
.kokoro/docker/docs/requirements.txtI created a follow up bug (b/390135527) to move this script internally.