build: add tests to template automation and clean up templating logic#2052
Merged
build: add tests to template automation and clean up templating logic#2052
Conversation
danieljbruce
approved these changes
Jan 15, 2025
danieljbruce
left a comment
danieljbruce
left a comment
There was a problem hiding this comment.
LGTM. I don't know too much about the synthtool though.
leahecole
approved these changes
Jan 16, 2025
sofisl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that closed issues prematurely due to formatting. Also adds tests so that library maintainers can update their own scripts if needed and know if they are breaking any automation.