chore: track customization in templates#1876
Merged
Conversation
Contributor
Author
|
Kokoro CI error: |
Contributor
Author
|
Changed test directory and only lint failed: |
suztomo
reviewed
Oct 4, 2023
SurferJeffAtGoogle
previously requested changes
Oct 4, 2023
suztomo
reviewed
Oct 13, 2023
suztomo
approved these changes
Oct 13, 2023
Member
suztomo
left a comment
There was a problem hiding this comment.
Think about the possibility of not needing partial_files arguments to java_library and _load_generic_metadata. If you still feel it's better to let users to explicitly specify the partial files, then I'm good. Approving either case.
chingor13
requested changes
Oct 16, 2023
Contributor
chingor13
left a comment
There was a problem hiding this comment.
Generally, looks ok to me
chingor13
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Append env_vars in all kokoro build configuration files (*.cfg in .kokoro/) which contain an
env_vars(key: JOB_TYPE, value: integration)When you want to append the environment variable too all templated .cfg which has an env_vars (key: JOB_TYPE, value: integration), follow the steps below:
Note that the file extension should be
.yaml.Modify default env_vars in Kokoro build templates
You don’t need to modify existing env_vars defined in the templates because if there are multiple env_vars with the same key, the last value will be used.
Please refer to Maps in proto 3 language guide.
Example
Append env_vars in configuration files with an env_vars (key: JOB_TYPE, value: integration)
.integration-partials.yamlto the repository root..integration-partials.yaml, add the following section:After the change
The following section will be appended to
.kokoro/nightly/integration.cfg.kokoro/nightly/java11-integration.cfg.kokoro/presubmit/integration.cfgBecause these files contain env_vars (key: JOB_TYPE, value: integration)
For env_var entry with key GCLOUD_PROJECT, the default value is overwritten by customized value (gcloud-devel) that appears later in the file.
Fix #1798.