Skip to content

chore: update requirements.txt to address dependabot security alerts#1829

Merged
alicejli merged 5 commits intomasterfrom
updateSecurityAlerts
Jul 24, 2023
Merged

chore: update requirements.txt to address dependabot security alerts#1829
alicejli merged 5 commits intomasterfrom
updateSecurityAlerts

Conversation

@alicejli
Copy link
Copy Markdown
Contributor

@alicejli alicejli commented Jul 13, 2023 •
edited by suztomo
Loading

Created by running:
pip-compile requirements.in --generate-hashes --upgrade within synthtool/docker/owlbot/java/src/ as well as synthtool/gcp/templates/java_library/.kokoro

Closes #1830

Closes #1802

Closes #1801

@alicejli alicejli requested review from a team and suztomo July 13, 2023 15:08
@alicejli
Copy link
Copy Markdown
Contributor Author

alicejli commented Jul 13, 2023

Kokoro check failing:

Executing: docker run --rm --interactive --network=host --privileged --volume=/var/run/docker.sock:/var/run/docker.sock --workdir=/tmpfs/src --entrypoint=github/synthtool/.kokoro/build.sh --env-file=/tmpfs/tmp/tmph267ibdj/envfile --volume=/tmpfs:/tmpfs gcr.io/cloud-devrel-kokoro-resources/python
nox > Running session lint-3.6
nox > Creating virtual environment (virtualenv) using python3.6 in .nox/lint-3-6
nox > Command /usr/local/bin/python3 -m virtualenv /tmpfs/src/github/synthtool/.nox/lint-3-6 -p python3.6 failed with exit code 1:
RuntimeError: failed to find interpreter for Builtin discover of python_spec='python3.6'
nox > Session lint-3.6 failed.
nox > Running session lint-3.10
nox > Missing interpreters will error by default on CI systems.
nox > Session lint-3.10 skipped: Python interpreter 3.10 not found.
nox > Running session test-3.6
nox > Creating virtual environment (virtualenv) using python3.6 in .nox/test-3-6
nox > Command /usr/local/bin/python3 -m virtualenv /tmpfs/src/github/synthtool/.nox/test-3-6 -p python3.6 failed with exit code 1:
RuntimeError: failed to find interpreter for Builtin discover of python_spec='python3.6'
nox > Session test-3.6 failed.
nox > Running session test-3.10
nox > Missing interpreters will error by default on CI systems.
nox > Session test-3.10 skipped: Python interpreter 3.10 not found.
nox > Ran multiple sessions:
nox > * lint-3.6: failed
nox > * lint-3.10: skipped
nox > * test-3.6: failed
nox > * test-3.10: skipped
cleanup

@alicejli
Copy link
Copy Markdown
Contributor Author

alicejli commented Jul 13, 2023 •
edited
Loading

googleapis/testing-infra-docker#301 should fix the test failure, and then #1826 will be merged as well.

@alicejli alicejli mentioned this pull request Jul 13, 2023
Merged
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Jul 13, 2023

Thank you

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Jul 14, 2023

@alicejli Can you add ones under synthtool/gcp/templates/java_library/.kokoro ?

That would resolve the items @kolea2 raised last week.

@alicejli
Copy link
Copy Markdown
Contributor Author

alicejli commented Jul 14, 2023

@alicejli Can you add ones under synthtool/gcp/templates/java_library/.kokoro ?

That would resolve the items @kolea2 raised last week.

Good call. Updated!

suztomo
suztomo approved these changes Jul 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this. Once all the checks pass, merge this.

@alicejli
Copy link
Copy Markdown
Contributor Author

alicejli commented Jul 17, 2023 •
edited
Loading

owlbot-java-presubmit test is failing the new-client-run build:

insertId: "c8dbabe4-d6f7-49fe-9ada-e8beea6fb9e8-612"
labels: {2}
logName: "projects/repo-automation-bots/logs/cloudbuild"
receiveTimestamp: "2023-07-17T17:43:32.285174411Z"
resource: {2}
severity: "INFO"
textPayload: "Step #3 - "new-client-run": TypeError: Descriptors cannot not be created directly."
timestamp: "2023-07-17T17:43:31.754014551Z"
...
insertId: "c8dbabe4-d6f7-49fe-9ada-e8beea6fb9e8-613"
labels: {2}
logName: "projects/repo-automation-bots/logs/cloudbuild"
receiveTimestamp: "2023-07-17T17:43:32.285174411Z"
resource: {2}
severity: "INFO"
textPayload: "Step #3 - "new-client-run": If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0."
timestamp: "2023-07-17T17:43:31.754015901Z"
---
Step #3 - "new-client-run": If you cannot immediately regenerate your protos, some other possible workarounds are:
2023-07-17 13:43:31.754 EDT
Step #3 - "new-client-run": 1. Downgrade the protobuf package to 3.20.x or lower.
2023-07-17 13:43:31.754 EDT
Step #3 - "new-client-run": 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

@suztomo IIUC, does this mean the code in synthtool/docker/owlbot/java/tests/new-client needs to be regenerated?

@parthea parthea mentioned this pull request Jul 21, 2023
Merged
@alicejli alicejli merged commit af76aa5 into master Jul 24, 2023
@alicejli alicejli deleted the updateSecurityAlerts branch July 24, 2023 14:19
holtskinner pushed a commit to holtskinner/synthtool that referenced this pull request Aug 1, 2023
@alicejli @parthea @holtskinner
chore: update requirements.txt to address dependabot security alerts (g…
f27c165 
…oogleapis#1829)

* chore: update dependencies in requirements.txt to address dependabot security alerts

* update dependencies within gcp/templates

---------

Co-authored-by: Anthonios Partheniou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suztomo suztomo suztomo approved these changes

+1 more reviewer

@SurferJeffAtGoogle SurferJeffAtGoogle SurferJeffAtGoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SurferJeffAtGoogle SurferJeffAtGoogle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alicejli @suztomo @SurferJeffAtGoogle @parthea