chore(java): omit -Penable-integration-tests parameter from native image test run command#1757
Merged
chore(java): omit -Penable-integration-tests parameter from native image test run command#1757
-Penable-integration-tests parameter from native image test run command#1757Conversation
…image test run command
BenWhitehead
approved these changes
Jan 30, 2023
Contributor
BenWhitehead
left a comment
BenWhitehead
left a comment
There was a problem hiding this comment.
An additional point of clarity:
Normally (for non-native builds), our config for surefire (and the test phase) will exclude integration tests from running, deferring those integration tests to failsafe and the integration-test phase. In the case of the native profile, we actually exclude unit tests from being run, and shift the integration tests patter from integration-test instead to test which native then uses.
Despite our change here saying we're not running integration tests, we in fact are and have been running them in the test phase for some time.
Contributor
Author
|
Thanks for the additional context @BenWhitehead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opting in of tests for native image testing is explicitly done in the
nativeprofile's maven-surefire-plugin. See https://github.com/googleapis/java-shared-config/blob/44a77b0faf5b4f3f9208117ccab0a3717d059efd/pom.xml#L806-L817 for reference. Therefore, the-Penable-integration-testsprofile is redundant.