Skip to content

chore: use gcp-docuploader 0.6.3#1708

Merged
mpeddada1 merged 2 commits intomasterfrom
downgrade-docuploader
Nov 10, 2022
Merged

chore: use gcp-docuploader 0.6.3#1708
mpeddada1 merged 2 commits intomasterfrom
downgrade-docuploader

Conversation

@mpeddada1
Copy link
Copy Markdown
Contributor

@mpeddada1 mpeddada1 commented Nov 10, 2022 •
edited
Loading

Using the latest version of gcp-docuploader (0.6.4) was resulting in:

Traceback (most recent call last):
  File "/root/.pyenv/versions/3.6.12/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/root/.pyenv/versions/3.6.12/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/root/.pyenv/versions/3.6.12/lib/python3.6/site-packages/docuploader/__main__.py", line 26, in <module>
    from docuploader.protos import metadata_pb2
  File "/root/.pyenv/versions/3.6.12/lib/python3.6/site-packages/docuploader/protos/metadata_pb2.py", line 5, in <module>
    from google.protobuf.internal import builder as _builder
ImportError: cannot import name 'builder'
cleanup

It looks like the latest version requires a newer version of the protobuf dependency (See: https://github.com/googleapis/docuploader/pull/137/files) . However versions greater than 3.19.6 are not compatible with Python 3.6.

@mpeddada1 mpeddada1 requested a review from a team November 10, 2022 22:04
@mpeddada1 mpeddada1 enabled auto-merge (squash) November 10, 2022 22:19
@mpeddada1 mpeddada1 merged commit fbc8bfe into master Nov 10, 2022
@mpeddada1 mpeddada1 deleted the downgrade-docuploader branch November 10, 2022 22:25
@anguillanneuf
Copy link
Copy Markdown

anguillanneuf commented Nov 10, 2022

Thank you both for looking and finding this update that introduced the error in javadoc publishing!

@mpeddada1 mpeddada1 mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees

@SurferJeffAtGoogle SurferJeffAtGoogle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mpeddada1 @anguillanneuf @lqiu96 @SurferJeffAtGoogle