Skip to content

chore(java): update dependencies in java requirements file#1695

Merged
mpeddada1 merged 9 commits intomasterfrom
update-deps-java
Nov 7, 2022
Merged

chore(java): update dependencies in java requirements file#1695
mpeddada1 merged 9 commits intomasterfrom
update-deps-java

Conversation

@mpeddada1
Copy link
Copy Markdown
Contributor

No description provided.

@mpeddada1 mpeddada1 requested a review from a team November 3, 2022 16:56
@mpeddada1 mpeddada1 changed the title chore(java): update gcp-releasetool and cryptography in java requirements file chore(java): update dependencies in java requirements file Nov 3, 2022
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Nov 3, 2022

Can you ensure that there's a check that runs pip install for the dependencies?

(I had to rollback a previous change recently #1674 )

@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Nov 3, 2022

Yes, that's a good idea. Was also wondering about this. Will create a small check that runs the install command in python 3.6.

@mpeddada1 mpeddada1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 3, 2022
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Nov 4, 2022

Mridula is going to get help from Jeff.

@suztomo
Copy link
Copy Markdown
Member

suztomo commented Nov 4, 2022

If the aforementioned check requires time, we can make it later (assuming you confirm pip install works for this pull request). When I asked, I assumed it's just adding a section in ".github/workflow/ci.yaml". Apparently this repository does not use GitHub Actions.

@mpeddada1
Copy link
Copy Markdown
Contributor Author

True. We can try using the existing owlbot-java-presubmit job to verify that the pip install command works successfully in Python 3.6.

@mpeddada1 mpeddada1 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 4, 2022
@mpeddada1
Copy link
Copy Markdown
Contributor Author

mpeddada1 commented Nov 4, 2022

The presubmit check has beeing taken into account:

Step #9: Successfully installed attrs-22.1.0 cachetools-4.2.4 certifi-2022.9.24 cffi-1.15.1 charset-normalizer-2.0.12 click-8.0.4 colorlog-6.7.0 cryptography-38.0.3 gcp-docuploader-0.6.4 gcp-releasetool-1.9.1 google-api-core-2.8.2 google-auth-2.14.0 google-cloud-core-2.3.1 google-cloud-storage-2.0.0 google-crc32c-1.3.0 google-resumable-media-2.3.3 googleapis-common-protos-1.56.3 idna-3.4 importlib-metadata-4.8.3 jeepney-0.7.1 jinja2-3.0.3 keyring-23.4.1 markupsafe-2.0.1 packaging-21.3 protobuf-3.19.5 pyasn1-0.4.8 pyasn1-modules-0.2.8 pycparser-2.21 pyjwt-2.4.0 pyparsing-3.0.9 pyperclip-1.8.2 python-dateutil-2.8.2 requests-2.27.1 rsa-4.9 secretstorage-3.3.3 six-1.16.0 typing-extensions-4.1.1 urllib3-1.26.12 zipp-3.6.0

Thanks again for your help @chingor13!

@mpeddada1 mpeddada1 enabled auto-merge (squash) November 7, 2022 15:40
Copy link
Copy Markdown
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see pip install succeed. thank you.

Screen Shot 2022-11-07 at 10 43 59 AM

@mpeddada1 mpeddada1 merged commit 74d0956 into master Nov 7, 2022
@mpeddada1 mpeddada1 deleted the update-deps-java branch November 7, 2022 15:45
suztomo added a commit to googleapis/google-cloud-java that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants