Skip to content

chore(python): exclude setup.py in renovate config#1570

Merged
parthea merged 1 commit intomasterfrom
parthea-patch-1
Sep 2, 2022
Merged

chore(python): exclude setup.py in renovate config#1570
parthea merged 1 commit intomasterfrom
parthea-patch-1

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Sep 2, 2022

I'd like to make a change to the renovate bot config to exclude setup.py for 2 reasons:

  1. It's proposing incorrect changes. For example, see https://github.com/googleapis/python-bigtable/pull/664/files where it is proposing to restrict the allowed range of google-api-core
  2. The setup.py for autogenerated libraries is currently handwritten. We're planning to migrate to an autogenerated setup.py in certain repositories. In that case, we wouldn't want renovatebot to propose changes since we would be autogenerating it.

We're planing to migrate from a handwritten setup.py to an autogenerated one and will maintain `setup.py` in the generator itself.
@parthea parthea requested a review from a team September 2, 2022 15:31
@parthea parthea merged commit 56da63e into master Sep 2, 2022
@parthea parthea deleted the parthea-patch-1 branch September 2, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants