fix: do not import the whole google-gax from proto JS#1553
Merged
alexander-fenster merged 1 commit intomasterfrom Aug 26, 2022
Merged
fix: do not import the whole google-gax from proto JS#1553alexander-fenster merged 1 commit intomasterfrom
alexander-fenster merged 1 commit intomasterfrom
Conversation
alexander-fenster
requested review from
SurferJeffAtGoogle,
bcoe and
chingor13
as code owners
bcoe
approved these changes
Aug 26, 2022
gcf-owl-bot Bot
added a commit
that referenced
this pull request
Aug 27, 2022
fix: use google-gax v3.3.0 Source-Link: c73d112 Post-Processor: gcr.io/repo-automation-bots/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
google-gaxversion to 3.3.0. The PR title corresponds to what I would like to see in the libraries' release notes.We will need this since it has the new
compileProtosscript that will help us uncouple gRPC and REST transports for Firestore.